HFP-3901 Add missing fileIcon definition#76
Merged
devland merged 1 commit intoh5p:masterfrom Apr 22, 2024
Merged
Conversation
otacke
changed the title
otacke
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged in, will add the
fileIcondefinition that the H5PEditor core expects.Currently, the
H5PIntegrationsetup for the H5PEditor core expects a defaultfileIconto be set that the file widget uses for binary files. The editor will crash if a binary file is uploaded without it.I'd technically expect h5p/h5p-editor-php-library#209 this to be the fix, in particular as no H5P integration so far provides a custom icon but always uses the default found in H5P core. But nothing seems to ever happen (those tiny non-brainer pull-requests were simply handled and merged back in the days), I am getting annoyed by all the quirks I have to live with here, so maybe on this repo the success rate of being recognized is higher.